Update gps_controller to not require location accuracy in android.#155
Open
reb1995 wants to merge 3 commits intoFoggedLens:mainfrom
Open
Update gps_controller to not require location accuracy in android.#155reb1995 wants to merge 3 commits intoFoggedLens:mainfrom
reb1995 wants to merge 3 commits intoFoggedLens:mainfrom
Conversation
Adds basic target matching. If Android Do... Else use old code.
Contributor
Author
|
Tested/confirmed working without location accuracy.
|
Remove extra import that isn't required. Now passes flutter analyze.
Contributor
Author
|
Updated the commit to remove an extra import that wasn't needed. Passing all tests now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have only tested this for Android. I do not know how to test for iOS, however it seems like it should work.
I believe this would fix: #149.
This updates the GpsController to explicitly use Android's native hardware Location Manager instead of the Fused Location Provider (FLP). This will prevent Google Services from attempting to handle the request and asking for location accuracy. This will require a full GPS lock to function and will take longer to get a location fix vs using Location Accuracy. I believe this to be a worthy trade off with this app, though.