plasmacli confirmsig query #185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesgraham
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
+ Coverage 51.75% 52.02% +0.27%
===========================================
Files 28 28
Lines 1314 1359 +45
===========================================
+ Hits 680 707 +27
- Misses 529 538 +9
- Partials 105 114 +9
Continue to review full report at Codecov.
|
colin-axner
reviewed
Jan 4, 2020
colin-axner
reviewed
Jan 13, 2020
hamdiallam
reviewed
Feb 28, 2020
hamdiallam
requested changes
Mar 5, 2020
Member
hamdiallam
left a comment
hamdiallam
left a comment
There was a problem hiding this comment.
Nice work! Looks great.
Can you do a full test? (run a node, submit tx, another tx requiring the confrim signatures, the retrieve the confirm sig using this command; testing when no confirm signatures are present, etc).
Contributor
Author
Tried depositing on the rootchain and running into a segfault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
add support for
plasmacli eth query sig <position>