Skip to content

fix: also refreshing for "turnOff" activated after first display in ssd1677 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theZiz wants to merge 1 commit into from
+16 −18
Closed

fix: also refreshing for "turnOff" activated after first display in ssd1677 #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions libs/display/FreeInkDisplay/src/driver/Ssd1677Driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,24 +425,22 @@ void Ssd1677Driver::displayImpl(EpdBus& bus, const uint8_t* fb, const uint8_t* p
// the single-pass HALF (0xD7 "_updateFull"); it never runs the multi-flash OTP
// full waveform (0xF7 is a dead fallback branch there). Promote to HALF where
// the board has one; boards without (Sticky) promote to their vendor FULL.
if (!turnOff) {
if (_needsInitialFull) {
// First paint after boot/wake must not be a differential FAST: it only drives
// pixels that differ from the RED baseline, so it can't clear whatever is
// physically on the panel (the boot screen) and that ghosts through. But a HALF
// or FULL the caller already asked for is non-differential (BYPASS_RED) and
// clears the panel + seeds the baseline on its own — honor it and just consume
// the one-shot. Only upgrade a FAST request. This keeps the boot logo (a HALF)
// from paying an extra multi-inversion FULL-waveform flash on top of its own.
if (mode == RefreshMode::Fast) mode = RefreshMode::Full;
_needsInitialFull = false;
mode = (_cfg.halfSeqOverride != 0) ? RefreshMode::Half : RefreshMode::Full;
} else if (!_isScreenOn && _cfg.fullSeqOverride == 0) {
// X4-class cold start: panel asleep -> a (warmed) HALF full-clear. Override
// boards skip this — their fast sequence self-powers, so _isScreenOn is false
// every page and forcing HALF would make every page a slow full-waveform flash.
mode = RefreshMode::Half;
}
if (_needsInitialFull) {
// First paint after boot/wake must not be a differential FAST: it only drives
// pixels that differ from the RED baseline, so it can't clear whatever is
// physically on the panel (the boot screen) and that ghosts through. But a HALF
// or FULL the caller already asked for is non-differential (BYPASS_RED) and
// clears the panel + seeds the baseline on its own — honor it and just consume
// the one-shot. Only upgrade a FAST request. This keeps the boot logo (a HALF)
// from paying an extra multi-inversion FULL-waveform flash on top of its own.
if (mode == RefreshMode::Fast) mode = RefreshMode::Full;
_needsInitialFull = false;
mode = (_cfg.halfSeqOverride != 0) ? RefreshMode::Half : RefreshMode::Full;
} else if (!turnOff && !_isScreenOn && _cfg.fullSeqOverride == 0) {
// X4-class cold start: panel asleep -> a (warmed) HALF full-clear. Override
// boards skip this — their fast sequence self-powers, so _isScreenOn is false
// every page and forcing HALF would make every page a slow full-waveform flash.
mode = RefreshMode::Half;
}

// Leaving grayscale content without the firmware's cleanup: stock parity — the
Expand Down