Repository navigation
Add crash-safe native protocol completion - #164
Merged
Merged
Conversation
Tim55667757
added
the
feature
ChatGPT Codex Connector
Tim55667757
commented
Nov 7, 2026
Tim55667757
left a comment
Tim55667757
left a comment
Contributor
Author
There was a problem hiding this comment.
Independent AI static review completed for exact head 7fa377a against d38094e. The separate reviewer inspected the implementation, fault regressions and EN/RU/ZH documentation; all findings are resolved, with no remaining actionable findings. Fixes cover durable pending absence after failed final directory synchronization, refusal of reappearing canonical sidecars before reservation retirement, and forwarding the new mutation keyword in an existing gate spy. Static review did not execute tests. Approval to proceed is conditional on all three exact-head CI gates succeeding; this COMMENT records AI review and does not impersonate a human APPROVE.
Tim55667757
marked this pull request as ready for review
November 7, 2026 09:24
Contributor
Author
|
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exposed native protocol operation needs a durable end state before ordinary WireGuard maintenance can resume. Add a private common finalizer that validates the exact generation, native/input terminal journals and independently observed unrelated services, then commits one immutable schema-2 completion before publishing its head and retiring verified sidecars and the reservation.
Recovery finishes exact historical metadata without claiming current service health. An incomplete exact completion prefix requires fresh terminal attestation. Unknown or reappearing sidecars, changed history and failed directory barriers retain protection; ordinary mutating WG admission reestablishes durable reservation absence before writing. Schema-1 unexposed cancellation remains compatible.
Continues #128; does not close it. Public CLI/RPC, a concrete unrelated-service observer, controller cloud attestation and epoch publication remain separate integration work. No desktop VPN, production server, cloud, key or network changes.
Validation on exact head 7fa377a:
Added 29 portable candidate/codec and 28 POSIX terminal, interruption, refusal and durability cases; every new POSIX case ran in Linux CI. ADR, engineering guidance and reviewed RU/ZH catalogs updated. Independent exact-head AI static review found no remaining actionable issues after the durability, sidecar-reappearance and gate-spy fixes; see the review COMMENT.