Skip to content

Slider units#116

Open
timmaffett wants to merge 4 commits into
GAM3RG33K:masterfrom
timmaffett:slider_units
Open

Slider units#116
timmaffett wants to merge 4 commits into
GAM3RG33K:masterfrom
timmaffett:slider_units

Conversation

@timmaffett
Copy link
Copy Markdown

This PR allows for 2 options to the SliderSettingsTile.
It allows simply adding a units string that is appended to the value,
and also adds a additional option of using a subtitleFormatterCallback for complete control of how the value is formatted and presented to the user.

GAM3RG33K
GAM3RG33K previously approved these changes Sep 11, 2024
Copy link
Copy Markdown
Owner

@GAM3RG33K GAM3RG33K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GAM3RG33K
Copy link
Copy Markdown
Owner

@timmaffett There seems to be some conflict of the formatter code, Can you please take the latest pull & update the PR?

Thanks alot for this contribution 😄

@timmaffett
Copy link
Copy Markdown
Author

timmaffett commented Sep 12, 2024

OK - It should be merged and resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants