cleanup use of logarithms #19
Conversation
…ases. a couple of derivatives wrt log fixed....need to finish this part
| REAL_TYPE const speciesConcentration_i = exp( logPrimarySpeciesConcentrations[i] ); | ||
| REAL_TYPE const speciesConcentration_i = logmath::exp( logPrimarySpeciesConcentrations[i] ); | ||
| aggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i; | ||
| dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i; |
There was a problem hiding this comment.
Should it be?
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst() * speciesConcentration_i;
azibitsker
left a comment
azibitsker
left a comment
There was a problem hiding this comment.
I went went through the changes and based on my current understanding of the framework, I think there is only one type of correction that I see in the derivative of aggregate wrt to log(C^primary) that should have a ln(10) factor in front of C_i.
| aggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i; | ||
| mobileAggregatePrimarySpeciesConcentrations[i] = speciesConcentration_i; | ||
| dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i; | ||
| dMobileAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = speciesConcentration_i; |
There was a problem hiding this comment.
Similarly, should it be?
dAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst() * speciesConcentration_i;
dMobileAggregatePrimarySpeciesConcentrationsDerivatives_dLogPrimarySpeciesConcentrations( i, i ) = logmath::dWrtLogConst() * speciesConcentration_i;
2 participants
Uh oh!
There was an error while loading. Please reload this page.