feat: Adding a script to generate schema #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paloma-martinez
changed the title
This reverts commit 5d7af1b.
jafranc
requested changes
Dec 18, 2025
Collaborator
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
I left a proposal for :
- simplify update of the schema files by fetching the schema on the GEOS repo and the commit numbers
- get the old-school regex to change all SomeThingType to SomeThing but the ProblemType due to its root-nature
Lmk if it is good for you and working.
Tested on multiple old commit, worked at least from 5368ee - Sept 2024.
Cannot go prior introduction of VtkWells
Comment on lines
44
to
48
| cd geos-trame | ||
| python -m venv pydantic-venv | ||
| source pydantic-venv/bin/activate | ||
| pip install -e . | ||
| pip install "xsdata[cli]" |
Collaborator
There was a problem hiding this comment.
This sounds like a workaround trick to avoid ruff inconsistent call in xsdata <=24.6.0. I'd rather enforce the use of xsdata>24.6.1 and it is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to generate easily the pydantic classes that depends on the GEOS schema.xsd file. As this schema may be slightly modified regularly, this process allows to have a dependable way to update it.