-
Notifications
You must be signed in to change notification settings - Fork 56
Palette cli #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: scripts-refac
Are you sure you want to change the base?
Palette cli #344
Conversation
|
How about script and stream commands. Could you add them too? 😉 If you branch this from #335 , it would be very easy. It makes sense especially with palette files, because it is not that easy to sort out what will be the index when loaded to GLVis. |
|
@justinlaughlin, can you resolve the conflicts? |
|
Updated to branch off of #335 ; I added script/stream commands. ping @najlkin @tzanio To test the script I ran this script with mesh/solution generated from a mfem example To test the stream I modified |
|
A rather tangential, but also when you change the palette, the number that is shown is off by one compared to the list 🫣 . |
|
Everything seems to work! 🤩 |
najlkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉 Pls mention it in changelog.
|
Ahh, I do not like that "palettes", that "palette_file" was better in my opinion 😛 I do not think that there must be consistency with command line parameters. This is rather confusing, because "palette" command takes the index and "palettes" a file 🤪 . |
-pnameor--palette-namePaletteState.SetFallbackIndex()overPaletteState.SetIndex()to specify a fallback index if the default is not specified (implementation would have been more invasive viaPaletteStateso it is done through the globalBasePalettes)