🐛 fix(skills): update the pt_map output for canonical angular containers - #775
Merged
nstarman merged 1 commit intoAug 20, 2026
Merged
Conversation
…iners `main` is red, and every open PR with it. GalacticDynamics#752 made `pt_map` return `Angle` for angular components rather than `Quantity` -- the point of that change -- but the `SKILL.md` doctest was written against the old behaviour and not updated: Expected {'r': Q(...), 'theta': Q(...), 'phi': Q(...)} Got {'r': Q(...), 'theta': Angle(...), 'phi': Angle(...)} `skills/` is in `testpaths`, so this fails the whole matrix on every branch that has GalacticDynamics#752 in its ancestry, which is now all of them. It is unrelated to whatever those branches touch. Mine to have caught. GalacticDynamics#752's doctest sweep ran over `src/`, `packages/`, `README.md` and `docs/`, and `skills/` was not in that list -- it arrived in GalacticDynamics#758, which merged after that branch's last full run and before GalacticDynamics#752 did, so no run on the branch ever saw the file. A sweep enumerated by hand missed a testpath the config already knew about; it should have read `testpaths`. Checked the rest of `skills/` for the same pattern rather than fixing only the reported line; that was the only occurrence.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the coordinax user skill doctest to reflect the post-#752 behavior where pt_map returns Angle containers for angular components, fixing a Sybil doctest failure that currently breaks CI for all branches based on main.
Changes:
- Adjusts the
pt_map(cart3d -> sph3d)example output inskills/coordinax/SKILL.mdto expectAngle(...)fortheta/phi. - Ensures the skill doctests align with current container canonicalization semantics introduced in #752.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 96.57% 96.71% +0.13%
==========================================
Files 267 268 +1
Lines 8963 9125 +162
==========================================
+ Hits 8656 8825 +169
+ Misses 307 300 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red, and every open PR with it.#752 made
pt_mapreturnAnglefor angular components rather thanQuantity— the point of that change — but theSKILL.mddoctest was written against the old behaviour and never updated:skills/is intestpaths, so this fails the entire matrix — every Python version, every OS — on any branch with #752 in its ancestry, which is now all of them. The failure is unrelated to whatever those branches actually change, so none of them can show a real CI signal until this lands.How it got through
Mine to have caught. #752's doctest sweep ran over
src/,packages/,README.mdanddocs/— a list I wrote by hand.skills/was not on it.The timing hid it:
SKILL.mdarrived in #758, which merged after #752's branch had its last full-suite run and before #752 itself merged. So no run on that branch ever saw the file, and the conflict only existed once both were inmain.The lesson is narrower than "run the full suite" — I did run it. It is that a hand-enumerated sweep can silently omit a path the config already knows about.
pyproject.tomlliststestpaths; the sweep should have read it rather than restated it.Scope
Checked the rest of
skills/for the same pattern rather than fixing only the reported line — that was the only occurrence.skills/: 49 passed.nox -s precommitclean. Full suite running.🤖 Generated with Claude Code