⬆️ dep-bump: cap coordinax below 0.24 - #809
Merged
Merged
Conversation
`coordinax>=0.23.3` has no upper bound. That is safe only by accident right now -- 0.23.3 is the latest release, so there is nothing above the floor to resolve to -- and it stops being safe the moment coordinax 0.24 lands, on an already-published galax wheel that cannot be changed. coordinax is 0.x and moves with galax: the floor has been raised on every release since 0.23.0 (GalacticDynamics#769, GalacticDynamics#774, GalacticDynamics#784, GalacticDynamics#792). GalacticDynamics#738 already capped it once, at `>=0.20.1,<0.21`, for an incompatible release; the cap was dropped in GalacticDynamics#744 when the floor moved past it. `unxt` carries `<2` for the same reason, and is currently earning it. Resolution is unchanged -- coordinax stays at 0.23.3 -- so this only edits the recorded specifier in the lock, matching GalacticDynamics#800. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 153 153
Lines 6079 6079
=======================================
Hits 5836 5836
Misses 243 243 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caps
coordinaxat<0.24ahead of the v0.0.3 release.Why
coordinax>=0.23.3currently has no upper bound. That is safe only by accident: 0.23.3 is the latest coordinax release, so there is nothing above the floor for a resolver to pick. It stops being safe the moment coordinax 0.24 lands — and by then the galax wheel is on PyPI and cannot be changed.The coupling is real, not hypothetical:
>=0.20.1,<0.21, explicitly for "an incompatible coordinax version". That cap was dropped in ⬆️ dep-bump: coordinax,diffrax,jax,quax(ed),unxt #744 only because the floor moved past it, not because it stopped being warranted.unxtcarries<2for exactly this reason (⬆️ dep-bump: cap unxt below 2.0 #800), and is currently earning it — unxt 2.0.1 is out. Worth noting coordinax 0.23.3 itself requiresunxt>=1.11.2uncapped, so galax's own cap is the only thing keeping unxt 2 out of a user's resolve.Scope
Resolution is unchanged — coordinax stays at 0.23.3 — so
uv.lockonly records the new specifier, one line, matching the shape of #800.uv lock --checkpasses, and the synced environment is identical.The trade-off is that a compatible coordinax 0.24 would need a galax release to unblock. Dependabot here covers only GitHub Actions plus security updates, so that bump is manual — which is already how these move (
⬆️ dep-bumpPRs).🤖 Generated with Claude Code