while viewing user profile, ensure you voted badge is handled correctly

[RamRamez]

• while viewing user profile, ensure you voted badge is handled correctly worldview-fe#85

Summary by CodeRabbit

• New Features

  • User activity data now includes a new indicator showing whether you have voted on each poll.

• Bug Fixes

  • Improved accuracy in displaying your voting status within user activities.

[coderabbitai]

Walkthrough

The getUserActivities functionality was updated to accept a worldID from the user context, enabling the service to determine if the requesting user has voted in each poll associated with the target user's activities. A new boolean field, hasVoted, was added to the response DTO to reflect this information.

Changes

File(s)	Change Summary
src/user/user.controller.ts	Modified getUserActivities to accept worldID from user context and pass it to the service.
src/user/user.dto.ts	Added hasVoted: boolean with @IsBoolean() to UserActionDto.
src/user/user.service.ts	Updated getUserActivities to accept requestingUserWorldID, cross-reference votes, and set hasVoted.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant UserController
    participant UserService
    participant Database

    Client->>UserController: GET /user/activities (with user context)
    UserController->>UserService: getUserActivities(query, worldID)
    UserService->>Database: Find requesting user by worldID
    alt User not found
        UserService-->>UserController: Throw UserNotFoundException
    else User found
        UserService->>Database: Get target user's actions
        UserService->>Database: Get polls from actions
        UserService->>Database: Get requesting user's votes for those polls
        UserService->>UserController: Return activities with hasVoted info
    end
    UserController->>Client: Respond with activities (hasVoted included)

Loading

Possibly related PRs

• return actionID in getUserActivities #36: Both PRs modify getUserActivities and UserActionDto, but focus on different fields (hasVoted vs actionID).
• Pull worldlD from middleware instead or request query/body #76: Both PRs update controller methods to extract worldID from user context using @User('worldID').
• add authorName to getUserActivities #82: Both PRs enhance getUserActivities and UserActionDto with additional fields (hasVoted vs author metadata).

Suggested reviewers

• lovelgeorge99

Poem

In the user fields where data grows,
Now a bunny hops and knows—
Who has voted, who has not,
With hasVoted neatly in the lot.
WorldID in paw, I leap with glee,
More informed our user tree!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea5c1c0 and 8420243.

📒 Files selected for processing (3)

• src/user/user.controller.ts (1 hunks)
• src/user/user.dto.ts (1 hunks)
• src/user/user.service.ts (4 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/user/user.service.ts (1)

src/common/exceptions.ts (1)

• UserNotFoundException (3-7)

src/user/user.controller.ts (2)

src/auth/user.decorator.ts (1)

• User (5-10)

src/user/user.dto.ts (1)

• UserActivitiesResponseDto (117-121)

🔇 Additional comments (6)

src/user/user.dto.ts (1)

113-114: LGTM! Clean addition of the hasVoted property.

The boolean property with proper validation decorator follows the established patterns in the DTO and correctly supports the voting status functionality.

src/user/user.controller.ts (1)

35-37: LGTM! Consistent implementation with other controller methods.

The addition of the @User('worldID') parameter and passing it to the service follows the same pattern used in other methods like getUserVotes, setVote, and editVote. This enables the service to determine voting status for the requesting user.

src/user/user.service.ts (4)

118-118: Good addition of requesting user context.

The method signature update to include requestingUserWorldID enables the voting status determination functionality and maintains consistency with other service methods.

---

129-137: Proper validation of requesting user.

Good security practice to validate that the requesting user exists before proceeding with the voting status checks. The error handling with UserNotFoundException is appropriate.

---

216-229: Efficient implementation of voting status lookup.

The logic correctly:

1. Collects poll IDs from user actions
2. Fetches requesting user's votes for those specific polls
3. Creates a Set for O(1) lookup performance

This is a clean and efficient approach to cross-reference voting data.

---

252-252: Correct implementation of hasVoted flag.

The hasVoted field is properly set using Set membership check, which provides accurate voting status information for each poll in the user's activities.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.