Repository navigation
feat: implement variant match search (issue #114) - #125
Open
jennifer-bowser wants to merge 19 commits into
Open
jennifer-bowser wants to merge 19 commits into
jennifer-bowser wants to merge 19 commits into
Conversation
…4-implement-match-search
jennifer-bowser
commented
Oct 30, 2026
korikuzma
requested changes
Oct 30, 2026
korikuzma
left a comment
korikuzma
left a comment
Member
There was a problem hiding this comment.
Please address the blocking correctness issues below before merging.
I strongly recommend keeping the reusable query function under src/anyvlm/outbound/ and moving the temporary interactive wrapper to an experimental script under scripts/. Shipping the wrapper inside the installed package and documenting its module invocation gives users an interface they may depend on. Replacing or removing it later could then require deprecation or breaking-change handling. Keeping it separate and explicitly experimental would make its intended lifetime clearer.
…4-implement-match-search
…e hard-coded test values
…4-implement-match-search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #114
This PR implements vvariant match searching against other VLM Network nodes (i.e., we can now make the same request to other nodes that they can make of us).
In the future we will want to have this functionality have a more formal interface (e.g., CLI functionality? etc.); however, for the sake of time I've implemented this as a simple script for now.
To test, run the scipt w/ the following command:
python -m src.anyvlm.scripts.run_variant_match.Due to time constraints, I haven't added any tests for this; instead I will add tests in issue #126