fix(upgrade): add 5-minute timeout to pre-upgrade backup#447
Closed
jorgehara wants to merge 1 commit into
Closed
Conversation
Prevents indefinite hangs when backing up large config directories (e.g., .cursor/extensions, .claude/projects with 1000s of files). Changes: - Add context.Context parameter to backup.Snapshotter.Create() - Wrap Create() call with 5-minute timeout in all locations - Check context cancellation between file operations - Update all tests to pass context.Background() - Graceful failure with warning if backup exceeds timeout Benefits entire community - not just Cursor users. Any large config directory (node_modules, IDE extensions, session history) could trigger this hang. Closes #446
abfebc5 to
53a3ad9
Compare
Alan-TheGentleman
requested changes
May 10, 2026
Contributor
Alan-TheGentleman
left a comment
There was a problem hiding this comment.
This is a useful bugfix, but the diff is too large for the stated behavior change.
Please add the required type:bug label and either split the context-plumbing churn from the timeout behavior or request a documented size:exception with a clear review boundary.
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #446
Summary
Changes
Test Plan
Contributor Checklist