test(cli): stabilize cross-platform env and path assertions#490
Closed
tonyblu331 wants to merge 1 commit into
Closed
test(cli): stabilize cross-platform env and path assertions#490tonyblu331 wants to merge 1 commit into
tonyblu331 wants to merge 1 commit into
Conversation
This was referenced May 9, 2026
14 tasks
This was referenced May 13, 2026
Isolate HOME/profile discovery side effects and normalize path-sensitive assertions so CLI integration tests behave consistently on Windows and Unix.
92f5af1 to
aa752ba
Compare
Contributor
Author
|
Closing this stale draft to clean up the Engram data-dir PR surface. The corrected work is being kept as a properly chained fork stack where each PR targets the previous branch and stays under the 400-line review budget. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Closes #103
🏷️ PR Type
type:chore— Build, CI, or tooling changes📝 Summary
Stabilizes
internal/clitests on Windows: isolateHOME/USERPROFILE/APPDATAfor agent discovery, setUSERPROFILEin restore tests, usecmd.exefor quiet failure output on Windows, normalize path assertions withfilepath.ToSlash, and use a tempGOBINonPATHfor the post-install note test.📂 Changes
internal/cli/cli_home_env_test.goisolateAgentDiscoveryEnv,ensureOpenCodeSDDNodeStubinternal/cli/sync_test.go,restore_test.go, …internal/cli/command_output_test.gointernal/cli/run_path_guidance_test.go,run_notes_test.go🧪 Test Plan
go test ./internal/cli/... -count=1🤖 Automated Checks
Review budget: 172 / 400 (
additions + deletions).✅ Contributor Checklist
status:approvedsize:exceptionwith rationale documentedtype:*label to this PRgo test ./...)cd e2e && ./docker-test.sh)Co-Authored-BytrailersChain Context
mainmaingo test ./internal/cli/...on WindowsChain Overview
Scope
feat/engram-dd-*branches)Autonomy
💬 Notes for Reviewers
Can land independently of the Engram data-directory stack. Supersedes overlapping test changes that were briefly on
feat/engram-data-dir-wiring-v2.