Open
Conversation
Updating this branch with the changes pushed to production in which a bunch of stuff was taken out. Better management here needed, more restraint. This is a time sink.
Take the nil until the last view to create loading screens. This produces cleaner code, and improves consistency in handling data (instead of deciding on different fallback values every time the property is used).
Missing: center routeOverview on current stop.
Its not gonna fly. It works bad.
To centralize the management of the sheet views.
Will be deleted later, but just for historic purposes. This might come handy later.
Remove SwiftUI dependency. Animations should be in views, not in controllers.
Even if status is disabled.
This reverts commit ecb5f23.
This reverts commit 5e71d44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.