Repository navigation
export-webhook: userinfo as Basic (as 1.5.5), and an auth header 1.5.5 could not build is left out - #24
Merged
Conversation
…, as 1.5.5's reqwest 0.12 sent it Audit export-webhook #1 (HIGH), ARCHITECT ruling (c). 1.5.5 POSTed through reqwest 0.12, whose RequestBuilder::new (extract_authority) took the URL's username and password off the URL, percent-decoded each (a username that is not UTF-8 sends nothing, a password that is not is left out) and appended basic_auth: 'Basic ' + padded standard base64 of '{user}:' then the password. The sink now builds that field from its own url setting and sends it first on every POST, then content-type, then the configured auth header, appended as http::HeaderMap appends: a configured header also named Authorization is sent too, after the userinfo's, as 1.5.5 sent both. The host's connector drops the userinfo from the target the url setting gives the need (busbar, same audit row). Log masking unchanged. Parity: a_userinfo_in_the_url_is_sent_as_basic_as_1_5_5_sent_it (reqwest's decoding and encoding cases, RFC 4648 vectors), the_userinfo_field_rides_beside_a_configured_auth_header_as_in_1_5_5.
…t out and the line still sent Audit export-webhook #4. Test only; it fails on this tree: an invalid header name or a value with a control byte is pushed as raw bytes, the host refuses the request, and every line is dropped. 1.5.5 skipped the header and delivered (THE DESIGN §2: "the default is 1.5.5's behaviour").
… the line still sent Audit export-webhook #4. 1.5.5 added the configured header only when HeaderName::from_bytes (1 to 65535 RFC 9110 token bytes) and HeaderValue::from_str (no control byte but tab, no DEL) took it, and POSTed the line without it otherwise; the sink pushed any bytes, the host refused the request, and every line was dropped. THE DESIGN §2: "A port keeps 1.5.5's surface ... wire bytes ... the default is 1.5.5's behaviour". RED: an_auth_header_1_5_5_could_not_build_is_left_out_and_the_line_still_sent.
MattJackson
force-pushed
the
lane-q128-sinks
branch
from
October 17, 2026 22:03
ca45bdd to
d60a073
Compare
…072 point at the warn lines, not the shed counter
…e secret (Q128 export-webhook M2)
…ader.value is marked x-busbar-secret: the release signs it in, and busbar resolves a reference there at open (Q128 export-webhook M2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #19 (a URL's userinfo sent as
authorization: Basic, as 1.5.5's reqwest 0.12 sent it; the commit busbar dev pins today), merged with dev, and audit export-webhook #4:1.5.5 added the configured auth header only when
HeaderName::from_bytesandHeaderValue::from_strtook it, and POSTed the line without it otherwise; the sink pushed any bytes and every line was dropped. Now the header is left out exactly where 1.5.5 left it out (THE DESIGN §2: "A port keeps 1.5.5's surface ... wire bytes ... the default is 1.5.5's behaviour").RED run (test-only commit a07f78f): 39001830681, failing
an_auth_header_1_5_5_could_not_build_is_left_out_and_the_line_still_sent. GREEN run: 39002692092 (every test and the conformance suite green; the job is red only at cargo-deny's advisories step, rustls RUSTSEC-2026-0346..0349 in this repo's lock at its busbar ref, unchanged by this PR).