fix: add company greeting fallback for blank names#128
Open
aagear wants to merge 2 commits into
Open
Conversation
Centralizes dashboard heading into getCompanyGreeting() helper that trims the name and falls back to 'Welcome back, there' when the company name is null, undefined, or whitespace-only. - frontend/lib/company-greeting.ts — helper function - frontend/lib/company-greeting.test.ts — 6 regression tests - frontend/app/app/company/page.tsx — use the helper References charles-openclaw/charles-microbounties#748
|
@aagear is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a centralized
getCompanyGreeting()helper that handles missing or blank company names gracefully, falling back to "Welcome back, there" instead of rendering a broken heading.Changes
frontend/lib/company-greeting.ts: new helper — trims the name, falls back to "there" for null/undefined/blankfrontend/lib/company-greeting.test.ts: 6 regression tests covering valid names, null, undefined, empty, and whitespacefrontend/app/app/company/page.tsx: switched to usegetCompanyGreeting()Fixes charles-openclaw/charles-microbounties#748