fix(delegation): backfill profiles.wallet_pubkey + document signer env — GHB-110#140
Open
aagear wants to merge 1 commit into
Open
fix(delegation): backfill profiles.wallet_pubkey + document signer env — GHB-110#140aagear wants to merge 1 commit into
aagear wants to merge 1 commit into
Conversation
|
@aagear is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110
Problem
On
/app/credentials, clicking "Authorize" fails withMissing NEXT_PUBLIC_PRIVY_SIGNER_ID env var.Even when that env var is present, MCPsubmissions.createandwhoamistill fail withProfile has no wallet pubkey.becauseprofiles.wallet_pubkeyis never populated during delegation.Changes
1. Backfill
profiles.wallet_pubkeyon delegate (agent-delegation-route-core.ts)After the
agent_delegationsupsert succeeds, updateprofiles.wallet_pubkeywhere it is currently null. This is best-effort (failure doesn't block delegation) and never overwrites an existing value.2. Document
NEXT_PUBLIC_PRIVY_SIGNER_IDin.env.exampleThe env var was missing from
.env.exampleentirely. Added with a comment explaining where to find the value in the Privy dashboard.3. Improve client-side error message (
AgentDelegationCard.tsx)Old error gave no actionable guidance. New message points developers to
frontend/.env.localand.env.example.4. Tests (3 new + existing refactored)
.eq("user_id", ...)and.is("wallet_pubkey", null)scoping