fix(auth): populate profiles.github_handle at signup and sync on update (GHB-110)#141
Open
aagear wants to merge 1 commit into
Open
fix(auth): populate profiles.github_handle at signup and sync on update (GHB-110)#141aagear wants to merge 1 commit into
aagear wants to merge 1 commit into
Conversation
|
@aagear is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110
Problem
Issue #110 reports that
profiles.wallet_pubkeyandprofiles.github_handlearenullfor newly registered dev accounts, blocking MCPsubmissions.createandwhoami.Existing PRs (#133, #139, #140) address
wallet_pubkeybackfill during delegation, but none fixgithub_handle-- the profiles table never gets the GitHub handle even though the developer signup form captures it.Root Cause
In
frontend/lib/auth-privy.tsx:persistDevRow: The
profilestable insert omitsgithub_handleentirely. Thedeveloperstable getsgithub_handle, butprofilesdoes not.updateUser: When a dev updates their GitHub handle, only the
developerstable is updated --profiles.github_handleis never synced.Changes
1. persistDevRow -- populate profiles.github_handle on signup
Add
github_handle: data.github ?? nullto the profiles insert. The data is already available from the onboarding form.2. updateUser -- sync github_handle to profiles on update
Extend
profilePatchto includegithub_handle. When a dev changes their GitHub handle, both profiles and developers tables are updated.Why this is the root-cause fix
The MCP auth path reads
profiles.github_handleandprofiles.wallet_pubkey. Existing PRs fixwallet_pubkeyreactively during delegation. This PR fixesgithub_handleproactively during signup so the profile row is correct from the start, not patched later.Testing