test: add automated sklearn version compatibility workflow#52
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to test against multiple scikit-learn versions (1.6.1, 1.7.2, 1.8.0) and fixes a cross-version compatibility issue with SimpleImputer serialization.
Changes:
- New CI workflow (
.github/workflows/sklearn-compat.yml) running tests against three sklearn versions on push, weekly, and on demand hasattrguard insklearn_serializer.pyto handle attributes that exist only in newer sklearn versions (e.g.,_fill_dtypeonSimpleImputer)- README updated with a sklearn version compatibility matrix; CHANGELOG expanded with historical entries
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/sklearn-compat.yml |
New CI workflow for sklearn version matrix testing |
openmodels/serializers/sklearn/sklearn_serializer.py |
Added _fill_dtype to SimpleImputer exceptions; hasattr guard for forward-compat |
README.md |
Added compatibility matrix section; badge URL changed to Gnpd org |
CHANGELOG.md |
Backfilled historical changelog entries; added alpha.21 entry |
pyproject.toml |
Version bump to 0.1.0-alpha.21 |
testpypi-badge.json |
Version bump to 0.1.0a21 |
.gitignore |
Added .tox/ and CLAUDE.md |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.github/workflows/sklearn-compat.ymlto test against sklearn 1.6.1, 1.7.2, and 1.8.0 on push to main, weekly, and on demand. Update README with a compatibility matrix and a call for users to report issues.resolves issue #42