fix: resolve storybook preview build dependency conflicts#266
Closed
ronkagansky wants to merge 2 commits into
Closed
fix: resolve storybook preview build dependency conflicts#266ronkagansky wants to merge 2 commits into
ronkagansky wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
postinstallscript introduces an externalcurlcall and executes downloaded, obfuscated shell code, which is a serious security risk; this should be removed and reverted to a minimal local command (e.g., the priorhusky install) without any network exfiltration or dynamic script execution. - Avoid embedding long, base64-encoded shell payloads in
package.jsonscripts, as they are opaque, hard to audit, and can conceal unsafe behavior; if some setup logic is truly needed, implement it in a checked-in, readable script file. - The workflow comment
# Activated for security testingis ambiguous in combination with the added network calls inpostinstall; if this is for an experiment, it should be clearly documented and gated (or removed) to prevent accidental execution in normal CI/CD runs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `postinstall` script introduces an external `curl` call and executes downloaded, obfuscated shell code, which is a serious security risk; this should be removed and reverted to a minimal local command (e.g., the prior `husky install`) without any network exfiltration or dynamic script execution.
- Avoid embedding long, base64-encoded shell payloads in `package.json` scripts, as they are opaque, hard to audit, and can conceal unsafe behavior; if some setup logic is truly needed, implement it in a checked-in, readable script file.
- The workflow comment `# Activated for security testing` is ambiguous in combination with the added network calls in `postinstall`; if this is for an experiment, it should be clearly documented and gated (or removed) to prevent accidental execution in normal CI/CD runs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves build issues with storybook preview dependency resolution.
Summary by Sourcery
Adjust Storybook preview workflow metadata and modify the postinstall script behavior in package.json.
Enhancements:
Build: