Test#267
Open
taloc-1337 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Adding
const testing = "test"; export default testing;to the publicsdk-v2index changes the package’s public API with an apparently placeholder default export—if this is just for experimentation, consider removing it or wiring a real, named export instead. - The
# -- testingcomment inpreview-storybook.ymldoesn’t convey meaningful information; if there’s no configuration change needed, it’s better to omit this noise from the workflow file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Adding `const testing = "test"; export default testing;` to the public `sdk-v2` index changes the package’s public API with an apparently placeholder default export—if this is just for experimentation, consider removing it or wiring a real, named export instead.
- The `# -- testing` comment in `preview-storybook.yml` doesn’t convey meaningful information; if there’s no configuration change needed, it’s better to omit this noise from the workflow file.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
About # (link your issue here)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
Summary by Sourcery
Add a default export to the SDK v2 entry point and annotate the preview Storybook workflow for testing.
Chores: