feat: github pat for authenticated install kustomize requests#103
Open
bnormington wants to merge 1 commit into
Open
feat: github pat for authenticated install kustomize requests#103bnormington wants to merge 1 commit into
bnormington wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds optional GitHub PAT authentication when the orb downloads
install_kustomize.shduring thedeploy-with-kustomizecommand and job.A new
github-pat-envparameter (defaultGITHUB_PAT) lets you point at a CircleCI environment variable that holds a GitHub personal access token. When that variable is set, the install script is fetched with anAuthorization: Bearerheader; when it is unset or empty, behavior stays the same as before with an unauthenticated download.This helps avoid GitHub rate limits and download failures when pulling from
raw.githubusercontent.comin CI, without requiring every project to configure a PAT. Unauthenticated API requests are capped at 60 per hour, while authenticated requests grant you up to 5,000 requests per hour.In CircleCI a new github-goodway-bot-public-readonly goodway context was added to hold the goodway-bot's public and readonly Personal Access Token. This token has no permissions. To configure update orb version and add the github-goodway-bot-public-readonly to the context list
You can also change the env var name if you want to build upon other settings.
TESTING
See CircleCI Job for authenticated request
See CircleCI Job for unauthenticated request