This repository was archived by the owner on Oct 11, 2025. It is now read-only.
Support equality filter in db.ListProperty#94
Open
eko-wibowo wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Support equality filter in db.ListProperty#94eko-wibowo wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
eko-wibowo wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
ka-role
pushed a commit
to Khan/appengine-mapreduce-1
that referenced
this pull request
Jul 7, 2018
It looks like the mapreduce code doesn't properly validate filters of list properties. I don't know if this fix is right, but we can try it! Implements GoogleCloudPlatform#94 Test plan: Fingers crossed Auditors: benkraft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db.ListProperty.validate expects the param to be a value to be assigned to the field (which is a List). However the .filter() method expects the value to be a single element. This issue only occurs for db.ListProperty, ndbProperty with repeated flag works just fine.
Without this changes:
With this changes