Skip to content

Remove deprecated Configuration.setVisible(boolean) call (Gradle 9.8) #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinbonnin merged 2 commits into from
Aug 27, 2026
Merged

Remove deprecated Configuration.setVisible(boolean) call (Gradle 9.8) #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65b7b4a
Remove deprecated Configuration.setVisible(boolean) call
breskeby Aug 26, 2026
6f01acc
Guard Configuration.setVisible(boolean) behind a Gradle < 9.8 check
breskeby Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion nmcp/src/main/kotlin/nmcp/internal/DefaultNmcpExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import org.gradle.api.Action
import org.gradle.api.Project
import org.gradle.api.publish.PublishingExtension
import org.gradle.api.publish.maven.MavenPublication
import org.gradle.util.GradleVersion

@GExtension(pluginId = "com.gradleup.nmcp", publicType = NmcpExtension::class, extensionName = nmcpExtensionName)
internal abstract class DefaultNmcpExtension(private val project: Project): NmcpExtension {
Expand All @@ -25,7 +26,12 @@ internal abstract class DefaultNmcpExtension(private val project: Project): Nmcp
it.isCanBeConsumed = true
it.isCanBeResolved = false
// See https://github.com/GradleUp/nmcp/issues/2
it.isVisible = false
// Without this, the publications end up being published as part of `assemble`.
// `Configuration.setVisible(boolean)` is deprecated as of Gradle 9.8 (and inert since),
// so only call it on older Gradle versions to stay warning-clean on 9.8+.
if (GradleVersion.current() < GradleVersion.version("9.8")) {
it.isVisible = false
}

it.configureAttributes(project)
}
Expand Down
Loading