Add resources for Pixel 10 series high EMF (PWM) mode setting #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SettingsGoogle resources are included in the stock OS for every Pixel model since the 6 series. config_availableEMValueOptions actually exists in AOSP, but is unused. blazer, mustang, and rango have device specific overlays in the stock OS to override the option to [0, 1], which actually enables the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: GrapheneOS/platform_packages_apps_Settings#390
The SettingsGoogle string resources are included in the stock OS for every Pixel model since the 6 series.
config_availableEMValueOptionsactually exists in AOSP (GrapheneOS/platform_frameworks_base@644b649), but is unused in AOSP Settings. blazer, mustang, and rango have device specific overlays in the stock OS to override the option to [0, 1], which actually enables the feature.I put the two string resources in the common files since the corresponding code in
packages/apps/Settingsgets built for every device.config_availableEMValueOptionsis left ingen10pixel.ymlsince only the Pixel 10 series enable the feature.I downloaded the latest stock OS release for all 20 devices from the Pixel 6 series through the Pixel 10 series and confirmed that the resources are present in all of them.