Fix ambiguous methods in KubeJS interop#4525
Merged
jurrejelle merged 9 commits intoGregTechCEu:1.20.1from Feb 8, 2026
Merged
Conversation
…ming the 'custom' setter to `customVeinGenerator` in KubeJS
…use `ResourceLocation...` for the KubeJS dimension setter rather than `String...`
This reverts commit ecb045d
Contributor
Author
|
update: reverted the OreVeinUtil optimization for now |
Member
|
shouldn't this target 8.0 instead? |
jurrejelle
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes all of the Rhino ambiguous method errors that I know of. Most of them were caused by overloaded methods, though some were from arguments 1.20 KubeJS doesn't have type wrappers for.
Implementation Details
Multiple methods were entirely hidden from KJS and replaced with one that accepts parameters KubeJS can parse properly.
Others, namely
GTOreDefinition#veinGenerator, was annotated with@RemapForJSto rename it so as to not conflict with a lombok-generated getter.Outcome
Less annoying to debug method conflicts in KubeJS.
How Was This Tested
Ran tests, tests ran. Also tested a simple KJS script that used the relevant methods, which worked.
Additional Information
The JVM ignores unknown annotations, so not having KubeJS/Rhino installed won't cause any errors.
Potential Compatibility Issues
Anyone using
BedrockFluidDefinition.Builder#dimensions(String...)orBedrockOreDefinition.Builder#dimensions(String...)will have to fix their code, but they shouldn't have been using that method anyway as it's always been intended for KubeJS use only.