Add `computeEdgeKBetweennessCentralities` function by Grufoony · Pull Request #440 · Grufoony/DynamicalSystemFramework

Grufoony · 2026-04-15T13:53:46Z

No description provided.

codecov · 2026-04-15T13:57:04Z

Codecov Report

❌ Patch coverage is 91.78082% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.00%. Comparing base (2f84b50) to head (0be3cc3).

Files with missing lines	Patch %	Lines
src/dsf/mobility/RoadNetwork.cpp	10.52%	17 Missing ⚠️
src/dsf/base/Network.hpp	94.64%	12 Missing ⚠️
test/mobility/Test_graph.cpp	99.18%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
+ Coverage   87.82%   88.00%   +0.17%     
==========================================
  Files          50       50              
  Lines        6850     7186     +336     
  Branches      793      850      +57     
==========================================
+ Hits         6016     6324     +308     
- Misses        805      832      +27     
- Partials       29       30       +1

Flag	Coverage Δ
unittests	`88.00% <91.78%> (+0.17%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-advanced-security

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copilot

Pull request overview

Adds a new edge “K-betweenness” centrality computation based on Yen’s K-shortest loopless paths (parallelized with TBB) and introduces unit tests to validate behavior for K=1 and K=2 on small graphs.

Changes:

Implement Network::computeEdgeKBetweennessCentralities() using Yen’s K-shortest paths with TBB parallel accumulation.
Refactor some Network inline accessors and internal helpers.
Add doctest coverage for computeEdgeKBetweennessCentralities() in mobility graph tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
`src/dsf/base/Network.hpp`	Adds Yen K-shortest-paths edge centrality implementation and refactors some inline helpers/accessors.
`test/mobility/Test_graph.cpp`	Adds tests validating K=1 consistency on a unique-path chain and K=2 increased centrality on a graph with alternative shortest paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-advanced-security

Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

                            )
-        with open("./src/dsf/.docstrings.hpp", "w") as f:
+
+        with open("./src/dsf/.docstrings.hpp", "w", encoding="UTF-8") as f:


                            )
-        with open("./src/dsf/.docstrings.hpp", "w") as f:
+
+        with open("./src/dsf/.docstrings.hpp", "w", encoding="UTF-8") as f:


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    std::vector<Id> nodeIds;
+    nodeIds.reserve(N_NODES);
+    for (auto const& [id, _] : m_nodes) {
+      nodeIds.push_back(id);
+    }


Copilot AI review requested due to automatic review settings April 15, 2026 13:53

github-advanced-security AI found potential problems Apr 15, 2026

View reviewed changes

Copilot started reviewing on behalf of Grufoony April 15, 2026 13:57 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread src/dsf/base/Network.hpp Outdated

Comment thread src/dsf/base/Network.hpp Outdated

Comment thread src/dsf/base/Network.hpp

Comment thread src/dsf/base/Network.hpp Outdated

Comment thread src/dsf/base/Network.hpp

Comment thread src/dsf/base/Network.hpp Outdated

Grufoony force-pushed the kBetweenness branch from 2fcd2f2 to 67c118c Compare April 27, 2026 11:51

github-advanced-security AI found potential problems Apr 27, 2026

View reviewed changes

Comment thread setup.py

)

with open("./src/dsf/.docstrings.hpp", "w") as f:

with open("./src/dsf/.docstrings.hpp", "w", encoding="UTF-8") as f:

github-advanced-security AI found potential problems Apr 27, 2026

View reviewed changes

Comment thread setup.py

)

with open("./src/dsf/.docstrings.hpp", "w") as f:

with open("./src/dsf/.docstrings.hpp", "w", encoding="UTF-8") as f:

Grufoony marked this pull request as draft April 27, 2026 16:00

Grufoony force-pushed the kBetweenness branch 5 times, most recently from aa9d87d to 3e96682 Compare April 28, 2026 15:29

Grufoony and others added 9 commits April 29, 2026 16:44

Init computeEdgeKBetweennessCentralities function

ab7d7b4

Bindings

c5fd127

Fix

e984d12

Writing csvs

49d3f92

Loggiaml

6962496

AI optimization

d4ed271

Secondo me non va

be35603

Fix

cda83eb

refactoring

667dbc9

Grufoony force-pushed the kBetweenness branch from 3e96682 to 667dbc9 Compare April 29, 2026 14:47

Grufoony and others added 2 commits April 29, 2026 17:41

Fix

7a0a015

Merge branch 'main' into kBetweenness

e8fc75a

Grufoony force-pushed the kBetweenness branch from 3de77e4 to e8fc75a Compare April 30, 2026 11:33

Grufoony added 2 commits April 30, 2026 15:06

Aggressive parallelization

09c0f67

No logging atm

d710952

Merge branch 'main' into kBetweenness

8171483

Grufoony marked this pull request as ready for review May 5, 2026 14:35

Grufoony requested a review from Copilot May 5, 2026 14:45

Copilot started reviewing on behalf of Grufoony May 5, 2026 14:46 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread src/dsf/base/Network.hpp Outdated

Comment thread src/dsf/base/Network.hpp

Comment thread src/dsf/mobility/RoadNetwork.cpp

Comment thread test/mobility/Test_graph.cpp

Grufoony added 2 commits May 5, 2026 16:54

Formatting

f52306c

Copilot fixes

0be3cc3

Grufoony requested a review from Copilot May 5, 2026 15:54

Copilot started reviewing on behalf of Grufoony May 5, 2026 15:54 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Copilot fixes [skip ci]

e6cca14

Grufoony changed the title ~~Init computeEdgeKBetweennessCentralities function~~ Add computeEdgeKBetweennessCentralities function May 6, 2026

Grufoony merged commit 3a78eea into main May 6, 2026

Grufoony deleted the kBetweenness branch May 6, 2026 07:38

Conversation

Grufoony commented Apr 15, 2026

Uh oh!

codecov Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-advanced-security AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 15, 2026 •

edited

Loading