Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 87.31% 87.31%
=======================================
Files 52 52
Lines 6628 6646 +18
Branches 765 768 +3
=======================================
+ Hits 5787 5803 +16
- Misses 817 819 +2
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Refactors the SQLite persistence logic in FirstOrderDynamics by extracting repeated insert code into dedicated helper methods and introducing a shared StreetDataRecord type for batching street writes.
Changes:
- Introduces
StreetDataRecordand newm_save*SQLhelper methods to centralize batch inserts. - Replaces inline SQL insert blocks inside
FirstOrderDynamics::evolve()with calls to the new helpers. - Adjusts average-stats calculation flow prior to persisting
avg_stats.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/dsf/mobility/FirstOrderDynamics.hpp |
Adds StreetDataRecord and declares new SQL save helper APIs (with some doc updates needed). |
src/dsf/mobility/FirstOrderDynamics.cpp |
Implements the SQL save helpers and wires them into evolve() in place of inline insert logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.