-
Notifications
You must be signed in to change notification settings - Fork 134
Enable the graph mode and add the full warmup logic for Deepseek OCR model #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the graph mode and add the full warmup logic for Deepseek OCR model #2138
Conversation
dd04d22 to
8f1c5fa
Compare
8c391a6 to
b560b50
Compare
b560b50 to
ebf2220
Compare
vllm/worker/hpu_model_runner.py
Outdated
| ''' | ||
|
|
||
| def __init__(self, is_batch_based): | ||
| def __init__(self, is_batch_based, sub_image_list=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to add the description of the argument of is_batch_based and sub_image_list in the defination.
sub_image_list seems like a list of image objects. But from line 117, maybe it is a list of integers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ebf2220 to
51dfa56
Compare
|
I verified the PR in full warmup mode, the result is unchanged. So it is OK. |
44f67ad to
e1ab76b
Compare
e1ab76b to
363a85a
Compare
czhu15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Deepseek OCR model uses fixed input tensor shape, so there is no need for padding.
Its input is different from the other MM models so a new fake data set is added to warm it up.