Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GitHub workflow automation to build the backend Docker image and updates ignore rules for OS-generated files.
Changes:
- Added a GitHub Actions workflow to build the backend container image and push to GHCR on
mainpushes (build-only on PRs). - Updated
.gitignorewith additional system file ignore patterns.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .gitignore | Adds OS/system ignore patterns (with some duplication vs existing entries). |
| .github/workflows/deploy-backend.yaml | New workflow to build/push the backend container image with caching and metadata tags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.
Suppressed comments (5)
backend/README.md:93
- This
docker runcommand referencesghcr.io/<org>/backend:latest, but the workflow publishesghcr.io/<org>/<repo>/backend:...(viaghcr.io/${{ github.repository }}/backend). As-is, readers won’t be able to pull/run the image built by CI.
docker run -p 8080:8080 -e DB_URL=jdbc:postgresql://my-db-host:5432/mydb -e DB_USER=admin -e DB_PASSWORD=secret ghcr.io/<org>/backend:latest
backend/README.md:87
- The GHCR image reference here doesn’t match what the workflow publishes. The workflow builds/pushes to
ghcr.io/${{ github.repository }}/backend(i.e.,ghcr.io/<org>/<repo>/backend), so this pull command will be wrong as written.
This issue also appears on line 93 of the same file.
docker pull ghcr.io/<org>/backend:latest
backend/README.md:207
- This section links to
deploy-backend.yaml, but that workflow file doesn’t exist in this PR (the added workflow isbackend-ci-cd.yaml). The link will be broken for readers.
Every push or PR touching `backend/**` runs [`deploy-backend.yaml`](../.github/workflows/deploy-backend.yaml):
backend/src/test/java/nl/hackyourfuture/project/backend/BackendApplicationTests.java:17
Assertions.assertTrue(true)is a tautology and doesn’t assert any meaningful behavior; it only makes the test look like it has a check. If the goal is simply “context loads”, an empty test body is sufficient (the test fails if the context can’t start).
@Test
void contextLoads() {
Assertions.assertTrue(true);
}
backend/pom.xml:13
- The project version is bumped to
1.0.0-SNAPSHOT, butbackend/README.mdstill instructs runningjava -jar target/backend-0.0.1-SNAPSHOT.jar. Please update the README (or use a version-agnostic command) so the docs match the built artifact name.
<version>1.0.0-SNAPSHOT</version>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.