Skip to content

Added Github workflows - #8

Merged
stasel merged 5 commits into
mainfrom
workflows
Aug 11, 2026
Merged

stasel merged 5 commits into
mainfrom
workflows

Conversation

@stasel

@stasel stasel commented Aug 11, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings August 11, 2026 20:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub workflow automation to build the backend Docker image and updates ignore rules for OS-generated files.

Changes:

  • Added a GitHub Actions workflow to build the backend container image and push to GHCR on main pushes (build-only on PRs).
  • Updated .gitignore with additional system file ignore patterns.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
.gitignore Adds OS/system ignore patterns (with some duplication vs existing entries).
.github/workflows/deploy-backend.yaml New workflow to build/push the backend container image with caching and metadata tags.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/backend-ci-cd.yaml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.

Suppressed comments (5)

backend/README.md:93

  • This docker run command references ghcr.io/<org>/backend:latest, but the workflow publishes ghcr.io/<org>/<repo>/backend:... (via ghcr.io/${{ github.repository }}/backend). As-is, readers won’t be able to pull/run the image built by CI.
docker run -p 8080:8080 -e DB_URL=jdbc:postgresql://my-db-host:5432/mydb -e DB_USER=admin -e DB_PASSWORD=secret ghcr.io/<org>/backend:latest

backend/README.md:87

  • The GHCR image reference here doesn’t match what the workflow publishes. The workflow builds/pushes to ghcr.io/${{ github.repository }}/backend (i.e., ghcr.io/<org>/<repo>/backend), so this pull command will be wrong as written.

This issue also appears on line 93 of the same file.

docker pull ghcr.io/<org>/backend:latest

backend/README.md:207

  • This section links to deploy-backend.yaml, but that workflow file doesn’t exist in this PR (the added workflow is backend-ci-cd.yaml). The link will be broken for readers.
Every push or PR touching `backend/**` runs [`deploy-backend.yaml`](../.github/workflows/deploy-backend.yaml):

backend/src/test/java/nl/hackyourfuture/project/backend/BackendApplicationTests.java:17

  • Assertions.assertTrue(true) is a tautology and doesn’t assert any meaningful behavior; it only makes the test look like it has a check. If the goal is simply “context loads”, an empty test body is sufficient (the test fails if the context can’t start).
	@Test
	void contextLoads() {
		Assertions.assertTrue(true);
	}

backend/pom.xml:13

  • The project version is bumped to 1.0.0-SNAPSHOT, but backend/README.md still instructs running java -jar target/backend-0.0.1-SNAPSHOT.jar. Please update the README (or use a version-agnostic command) so the docs match the built artifact name.
	<version>1.0.0-SNAPSHOT</version>

@stasel
stasel merged commit 2fb9b48 into main Aug 11, 2026
4 checks passed
@stasel
stasel deleted the workflows branch August 11, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants