Repository navigation
Conversation
Editkin is developed as a local desktop app and has no official web deployment. Remove the manual Pages workflow, the root .nojekyll, the social-preview meta tags and og-image copy, and the EDITKIN_SITE_URL Vite plugin that only that workflow supplied. Keep the favicon for the npm run dev browser tab, and describe the browser UI in the READMEs as a development aid only. Signed-off-by: Hao0321 <126182090+Hao0321@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YQbUWKu73ka7dZ58vWVzgY
This was referenced Oct 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Editkin is a local desktop app. The automatic workflows, video export, autosave/recovery, the native engines and agent integration all need the local runtimes, so the browser build could only ever be a reduced demo. This PR removes the public web deployment that #53, #55 and #56 added:
.github/workflows/pages.yml(manual, owner-gated Pages deploy) and the root.nojekyllindex.html: removed the Open Graph and Twitter social-preview tags and the "browser trial" description; kept the favicon links used by thenpm run devbrowser tabvite.config.ts: removed theeditkin-site-urlplugin, which only acted when the Pages workflow setEDITKIN_SITE_URLscripts/build-web-public.mjs: no longer copiesog-image.png; still copiesfavicon.icoREADME.md/README.zh-TW.md: the "Browser build" sections now say Editkin is desktop-first, thatnpm run devis a development aid only, and that there is no official web deploymentThe in-app messages that disable engine-backed actions when the UI runs in a browser (#73) stay, because
npm run devstill runs there.If GitHub Pages is enabled under Settings → Pages, turn it off there too; removing the workflow does not unpublish an existing site. A contributor-hosted copy at
yueyuhoshizora.github.io/Editkinis outside this repository.User journey and platform
The desktop app is unchanged. Contributors still use
npm run devin a browser for development.Validation
npm run source:verify:self-test: GREENnpm run source:scan: GREENnpm run typecheck,npm run build: passed;dist/index.htmlcontains noog:tagsnpm test: 279 files passed, 1 skipped; 2168 tests passed, 5 skippedEDITKIN_SITE_URL,og-image,pages.ymlor.nojekyllSecurity and provenance
This removes a deployment path (the
pages: write/id-token: writejob) and adds nothing: no dependencies, network access, process execution, file writes, media, fonts or models. No secrets or private footage.DCO
The commit has a
Signed-off-by:trailer.🤖 Generated with Claude Code
https://claude.ai/code/session_01YQbUWKu73ka7dZ58vWVzgY
Generated by Claude Code