Make sure Git SHA is for the Flixel repository #3322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
requested changes
Dec 13, 2025
Member
Geokureli
left a comment
Geokureli
left a comment
There was a problem hiding this comment.
FlxGitSHA was deprecated, very recently. Use the new FlxVersionMacro tool, instead
Contributor
Author
|
I wasn't using it directly. It's used by FlxVersion and by extension the debugger to show the version in the top left. I'm not sure if it still happens with the new versioning tool, I'll have to check. Either way I'll close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rev-parse HEAD(which is what FlxGitSHA.hx uses to get the current commit SHA) will get the current commit of a git repostory, EVEN in subdirectories.So if you have a project with a git repository and a .haxelib folder with a haxelib release of Flixel, FlxGitSHA will get the project's current git commit thinking that it's Flixel's current commit
This PR adds a
--show-toplevelargument to the command which returns the path of the git repository and compares it with the path fromgetLibraryPath()Merry Christmas!