Skip to content

fix: 双端比较在非理想情况时, 获取 idxInOld 需要判断 node 是否为空 #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 双端比较在非理想情况时, 获取 idxInOld 需要判断 node 是否为空 #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/zh/renderer-diff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ while (oldStartIdx <= oldEndIdx && newStartIdx <= newEndIdx) {
} else {
// 遍历旧 children，试图寻找与 newStartVNode 拥有相同 key 值的元素
const idxInOld = prevChildren.findIndex(
node => node.key === newStartVNode.key
node => node?.key === newStartVNode.key
)
}
}
Expand All @@ -908,7 +908,7 @@ while (oldStartIdx <= oldEndIdx && newStartIdx <= newEndIdx) {
} else {
// 遍历旧 children，试图寻找与 newStartVNode 拥有相同 key 值的元素
const idxInOld = prevChildren.findIndex(
node => node.key === newStartVNode.key
node => node?.key === newStartVNode.key
)
if (idxInOld >= 0) {
// vnodeToMove 就是在旧 children 中找到的节点，该节点所对应的真实 DOM 应该被移动到最前面
Expand Down Expand Up @@ -948,7 +948,7 @@ while (oldStartIdx <= oldEndIdx && newStartIdx <= newEndIdx) {
// 省略...
} else {
const idxInOld = prevChildren.findIndex(
node => node.key === newStartVNode.key
node => node?.key === newStartVNode.key
)
if (idxInOld >= 0) {
const vnodeToMove = prevChildren[idxInOld]
Expand Down Expand Up @@ -991,7 +991,7 @@ while (oldStartIdx <= oldEndIdx && newStartIdx <= newEndIdx) {
// 省略...
} else {
const idxInOld = prevChildren.findIndex(
node => node.key === newStartVNode.key
node => node?.key === newStartVNode.key
)
if (idxInOld >= 0) {
const vnodeToMove = prevChildren[idxInOld]
Expand Down