docs(ui): commit the #237/#238 interactive mockups into the repo#247
Closed
angela-helios wants to merge 1 commit into
Closed
docs(ui): commit the #237/#238 interactive mockups into the repo#247angela-helios wants to merge 1 commit into
angela-helios wants to merge 1 commit into
Conversation
The mockups for the Compartment Editor (#237) and SearchParameter Editor (#238) were only reachable through hosted artifact links, which went dead and were unviewable for part of the team. They are self-contained HTML (fonts and data embedded, no network), so they now live in docs/mockups/ where anyone can open them from a checkout, with static PNG previews alongside. Both are loaded with real repo data (the 1,375-param R4 registry and the five R4 CompartmentDefinitions) and follow the helios-ui design system verbatim. The README states their relationship to the real screens: prototypes whose inline JS stands in for the htmx fragment swaps the crate actually uses; real markup lands in templates/ when the screens are built.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mockups for the Compartment Editor (#237) and SearchParameter Editor (#238) were only reachable through hosted artifact links, which went dead and were unviewable for part of the team. They are fully self-contained HTML (fonts and real repo data embedded, zero network), so this puts them in
docs/mockups/where anyone can open them from a checkout — with static PNG previews alongside for a quick look without opening anything.search-parameter-editor.html(SearchParameter viewer & editor UI: Resource Filter rail, faceted browse, CRUD with registry-aware validation #238): the real 1,375-param R4 registry, Resource Filter rail with live counts, type/source facets, read-onlyEmbeddedrows with Create override, live validation reflecting the fix(search): resolve (base, code) shadowing by source precedence #242 semantics (cross-source shadow =overrides specchip; same-source collision = blockingconflict/DuplicateCode), and two synthetic tenant parameters exercising the write paths.compartment-editor.html(Compartment Editor UI: CRUD for CompartmentDefinitions + a compartment route tester #237): the five real R4 CompartmentDefinitions (Patient 66 / Practitioner 59 / RelatedPerson 32 / Device 32 / Encounter 25, of 145 types), dirty-tracked Definition tab with thesearch/experimentalswitches, Members tab with member/excluded chips and param CRUD, and the route Tester (member via params + rendered flat search, non-member 404 + OperationOutcome,/*fan-out with skip-not-fail).The README states their relationship to the real screens: these are prototypes whose inline JS stands in for the htmx fragment swaps the crate actually uses — real markup lands in
templates/when the screens are built (the compartment tester as aGETfragment endpoint is the natural first slice, per #237's open question 2).Refs #237, #238 (not
Closes— the issues track the real screens).