Skip to content

i18n: localize Cmd command output messages (15 MessageIds)#2940

Closed
gordonlu wants to merge 1 commit into
Hmbown:mainfrom
gordonlu:feat/i18n-cmd-output
Closed

i18n: localize Cmd command output messages (15 MessageIds)#2940
gordonlu wants to merge 1 commit into
Hmbown:mainfrom
gordonlu:feat/i18n-cmd-output

Conversation

@gordonlu

@gordonlu gordonlu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Localize all Cmd* command output messages across 7 shipped locales.

What's covered

  • CmdErrorPrefix — localized "Error:" prefix via CommandResult::error_localized()
  • CmdTaskUsage{Add,Show,Cancel,General} — /task usage hints
  • CmdTrust{Enabled,Disabled,UnknownAction} — /trust status messages
  • CmdLsp{Status,Enabled,Disabled,UnknownArg} — /lsp diagnostics messages
  • CmdLogout{Success,Failed} — /logout messages
  • CmdEditingQueuedDraft — queue list header for active draft

Changes

  • localization.rs: 15 new MessageIds + translations in all 7 locales
  • commands/mod.rs: new CommandResult::error_localized() with localized error prefix
  • commands/task.rs: all usage error messages via tr()
  • commands/config.rs: trust/lsp/logout messages via tr()
  • commands/queue.rs: editing-queued-message header via tr()

Testing

  • 4338 tests pass, 1 pre-existing flaky MCP SSE test failure
  • clippy clean with -D warnings
  • cargo fmt --all --check clean

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request localizes command-line output messages across several commands, including /trust, /lsp, /logout, /queue, and /task. It introduces a new error_localized helper to format localized error messages with a localized prefix, adds new message IDs to the localization system, and provides translations for English, Vietnamese, Chinese, Japanese, Portuguese, and Spanish. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Hmbown

Hmbown commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Thanks @gordonlu — we merged #2891 and #2896 from your i18n batch tonight, which moved localization.rs on main, so this slice now shows as conflicting. Could you rebase it onto current main when you get a chance?

Since the slices all touch localization.rs, the smoothest path is to rebase and push them one at a time, oldest-first (#2892#2901#2918#2919#2921#2926#2929#2932#2940) — we'll merge each promptly so the next rebase stays small. Sorry for the churn; the batch is exactly the right shape and we want all of it.

@Hmbown Hmbown added v0.8.59 Targeting v0.8.59 localization Localization, i18n, and non-English language support labels Jun 11, 2026
@Hmbown Hmbown added this to the v0.8.59 milestone Jun 11, 2026
@Hmbown Hmbown added the ux User experience, interaction, or presentation polish label Jun 11, 2026
@Hmbown

Hmbown commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Closing this smaller i18n PR as superseded by the consolidation lane in #2239. #2239 covers the same surface area at broader Phase 1-4b scope and is the preferred v0.8.59 review target, though it still has its own outstanding review/fix work before merge.

@Hmbown Hmbown closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localization Localization, i18n, and non-English language support ux User experience, interaction, or presentation polish v0.8.59 Targeting v0.8.59

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants