-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
patchpal 0.4.0 (new formula) #254017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
patchpal 0.4.0 (new formula) #254017
Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
The CI failure here appears to be "this fork isn't popular", which makes sense, given that I literally just created it today. Is that really a requirement to get a package included? |
5960fe6 to
1ba5139
Compare
That was for the first push, and appears to have gone away when I fixed another issue. |
1ba5139 to
3a3d333
Compare
Just noticed that there's a bit about new formula passing Also amusing that it says GitLab there, when we're working on GitHub here. |
1d75148 to
94eae93
Compare
6e16289 to
83b3349
Compare
Initial homebrew packaging. This is software developed by some folks at Red Hat, looking to improve the patch backporting experience, even for those using macOS. It's a rust-based frontend that can be run entirely without the backend, but can also hook into a python-based backend AI server that helps provide AI assistance with backporting patches from a development branch to an older stable maintenance branch, such as, say, from the upstream Linux kernel branch to an old Red Hat Enterprise Linux kernel branch. Signed-off-by: Jarod Wilson <[email protected]>
83b3349 to
8a47de3
Compare
|
Okay, self-tests now executing and passing on all platforms after jumping through some hoops to get a functioning X server for the linux case. |
| inreplace "tests/run.sh", "readlink -e", "echo" | ||
| inreplace "tests/run.sh", "target/release/patchpal", "bin/patchpal" | ||
| inreplace "tests/run.sh", "awk", "gawk" | ||
| inreplace "tests/run.sh", "not ok $count", "fail $count" | ||
| inreplace "tests/run.sh", "ok $count", "pass $count" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test the functionality of the binary directly in some other way instead of editing the tests here? It would also mean we don't need to install the tests to the prefix.
https://docs.brew.sh/Formula-Cookbook#add-a-test-to-the-formula
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. Maybe? The readlink bit does not function with the version of readlink present on macOS though. I'm one of the people actually working on the patchpal project itself though, and have already been discussing with the primary maintainer some changes to the test script to make it behave better elsewhere. So some of these changes being made by inreplace are already merged, they're just not in 0.4.0. I'll see what else I can figure out, but the readlink bit might be a hard blocker until we replace that upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got pending changes for patchpal that will take care of this over here:
https://gitlab.com/patchpal-ai/patchpal-gui/-/merge_requests/23
But we'll need a new patchpal release before I can drop those inreplace bits and run w/o installing, or add a patch to the build, I guess? Not quite sure how that all works here, most of my packaging experience is with rpm. :)
The download url is on GitLab though. |
Initial homebrew packaging.
This is software developed by some folks at Red Hat, looking to improve
the patch backporting experience, even for those using macOS. It's a
rust-based frontend that can be run entirely without the backend, but can
also hook into a python-based backend AI server that helps provide AI
assistance with backporting patches from a development branch to an older
stable maintenance branch, such as, say, from the upstream Linux kernel
branch to an old Red Hat Enterprise Linux kernel branch.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?