fix: add missing numpy import in _11_merge_audio.py#550
Open
wearshoes wants to merge 1 commit intoHuanshere:mainfrom
Open
fix: add missing numpy import in _11_merge_audio.py#550wearshoes wants to merge 1 commit intoHuanshere:mainfrom
wearshoes wants to merge 1 commit intoHuanshere:mainfrom
Conversation
The `load_and_flatten_data` function uses `eval()` to parse `new_sub_times` from Excel. When `_10_gen_audio.py` writes `np.float64` values, they serialize as `np.float64(...)` strings. Without `import numpy as np`, `eval()` raises `NameError: name 'np' is not defined`. Fixes Huanshere#543 Fixes Huanshere#544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import numpy as nptocore/_11_merge_audio.pyto fixNameError: name 'np' is not definedduring audio mergingProblem
_10_gen_audio.pysavesnew_sub_timesto Excel withnp.float64values. When serialized to string, they becomenp.float64(16.496)._11_merge_audio.pyuseseval()to parse these strings but doesn't import numpy, causing:Root Cause
In
_11_merge_audio.py:22,eval()is called on strings like[[np.float64(16.496), np.float64(19.116)]]butnp(numpy) is not in scope.Fix
Add
import numpy as npat the top ofcore/_11_merge_audio.py.Fixes #543
Fixes #544
Test plan