fix: sync detected_language when recognition language is changed in frontend#551
Open
octo-patch wants to merge 1 commit intoHuanshere:mainfrom
Open
fix: sync detected_language when recognition language is changed in frontend#551octo-patch wants to merge 1 commit intoHuanshere:mainfrom
octo-patch wants to merge 1 commit intoHuanshere:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #549
Problem
When a user switches the recognition language in the frontend sidebar, only
whisper.languagewas updated in the config, butwhisper.detected_languagewas left unchanged. This caused NLP segmentation failures and other issues in subsequent steps because:core/spacy_utils/load_nlp_model.pyreadswhisper.detected_languageto pick the right NLP model (when language is not English)core/_3_2_split_meaning.pyreadswhisper.detected_languagewhenwhisper.languageis set toautoSolution
When the user manually selects a recognition language, also update
whisper.detected_languageto the same value, so both fields stay in sync.Testing
Manually verified that after changing the recognition language in the UI sidebar,
whisper.detected_languagein the config is correctly updated to match the selected language.