ci: add cargo clippy with deny warnings - #567
Open
Divine-mercyx wants to merge 1 commit into
Open
Conversation
The crate-level allow(warnings) made the existing clippy job a no-op. Replace it with targeted allows and lint fixes so CI catches new warnings. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-D warningsby removing the crate-level#![allow(warnings)]indongle-smartcontract/src/lib.rs.mut, dead helpers,too_many_arguments) socargo clippy -p dongle-contract --target wasm32-unknown-unknown -- -D warningspasses.--all-featuresso new warnings fail the lint job.Type of Change
Changes Made
#![allow(warnings)]from the contract crate.#[allow(clippy::too_many_arguments)]and#[allow(dead_code)].get_project_region/get_project_integrity_hashthroughProjectRegistryinstead of duplicating storage reads.--all-features.Acceptance Criteria
cargo clippywith deny warnings.allow(warnings)inlib.rsis removed rather than left crate-wide.Testing
cargo clippy -p dongle-contract --target wasm32-unknown-unknown --all-features -- -D warningscargo test -p dongle-contract region_and_integrityCloses #511
Made with Cursor