Fix event symbolics cache
#4507
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pschanely/hypothesis-crosshair#41.
There are two problems here:
contro._events_to_stringswas a cache which persisted symbolics. We disable this now underavoid_realization.describe_statisticseven when observability is not enabled. Because we gated realization behind observability being enabled,data.eventsmight be symbolic in the pytest plugin. This patch makes the realization unconditional. In the future I want to investigate unifying the pytest statistics reporting with observability, so we have the single observability path, and the pytest plugin simply adds an observability callback.