Skip to content

feat(CIS): add ruleset to modules #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirijaibm merged 1 commit into from
Sep 4, 2025
Merged

feat(CIS): add ruleset to modules #150

sirijaibm merged 1 commit into from
Sep 4, 2025

Conversation

@sirijaibm
Copy link
Collaborator

@sirijaibm sirijaibm commented Sep 3, 2025 •
edited
Loading

PR summary

Added rulesets to cis modules

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sirijaibm
Copy link
Collaborator Author

sirijaibm commented Sep 3, 2025

UTs:

>>mvn test                     
WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::staticFieldBase has been called by com.google.inject.internal.aop.HiddenClassDefiner (file:/opt/homebrew/Cellar/maven/3.9.11/libexec/lib/guice-5.1.0-classes.jar)
WARNING: Please consider reporting this to the maintainers of class com.google.inject.internal.aop.HiddenClassDefiner
WARNING: sun.misc.Unsafe::staticFieldBase will be removed in a future release
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< com.ibm.cloud:rulesets >-----------------------
[INFO] Building Cloud Internet Services rulesets 99-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] Parameter 'systemPropertyVariables' is unknown for plugin 'jacoco-maven-plugin:0.8.13:prepare-agent (prepare-agent)'
[WARNING] Parameter 'systemPropertyVariables' is unknown for plugin 'jacoco-maven-plugin:0.8.13:report (report)'
[INFO] 
[INFO] --- buildnumber:3.2.1:create (default) @ rulesets ---
[INFO] ShortRevision tag detected. The value is '8'.
[INFO] Executing: /bin/sh -c cd '/Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets' && 'git' 'log' '-1' '--no-merges' '--format=format:%H %aI %aE %aN'
[INFO] Working directory: /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets
[WARNING] The timestampFormat parameter now uses java.text.SimpleDateFormat.
[WARNING] Please update your POM as support for java.text.MessageFormat may be removed.
[INFO] Storing buildNumber: 5b72630d at timestamp: 20250903-122328
[INFO] Executing: /bin/sh -c cd '/Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets' && 'git' 'symbolic-ref' 'HEAD'
[INFO] Working directory: /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets
[INFO] Storing scmBranch: master
[INFO] 
[INFO] --- jacoco:0.8.13:prepare-agent (prepare-agent) @ rulesets ---
[INFO] argLine set to -javaagent:/Users/sirija/.m2/repository/org/jacoco/org.jacoco.agent/0.8.13/org.jacoco.agent-0.8.13-runtime.jar=destfile=/Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/target/jacoco.exec
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ rulesets ---
[INFO] skip non existing resourceDirectory /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/src/main/resources
[INFO] 
[INFO] --- compiler:3.14.0:compile (default-compile) @ rulesets ---
[INFO] Nothing to compile - all classes are up to date.
[INFO] 
[INFO] --- resources:3.3.1:testResources (default-testResources) @ rulesets ---
[INFO] skip non existing resourceDirectory /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/src/test/resources
[INFO] 
[INFO] --- compiler:3.14.0:testCompile (default-testCompile) @ rulesets ---
[INFO] Nothing to compile - all classes are up to date.
[INFO] 
[INFO] --- surefire:3.5.3:test (default-test) @ rulesets ---
[INFO] Using auto detected provider org.apache.maven.surefire.testng.TestNGProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
[INFO] Tests run: 164, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.800 s -- in TestSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 164, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco:0.8.13:report (report) @ rulesets ---
[INFO] Loading execution data file /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/target/jacoco.exec
[INFO] Analyzed bundle 'Cloud Internet Services rulesets' with 108 classes
[INFO] 
[INFO] --- checkstyle:3.6.0:check (verify-style) @ rulesets ---
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  6.935 s
[INFO] Finished at: 2025-09-03T12:23:35+05:30
[INFO] ------------------------------------------------------------------------



ITs:

>>mvn test -Dtest=RulesetsIT -e                       
WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::staticFieldBase has been called by com.google.inject.internal.aop.HiddenClassDefiner (file:/opt/homebrew/Cellar/maven/3.9.11/libexec/lib/guice-5.1.0-classes.jar)
WARNING: Please consider reporting this to the maintainers of class com.google.inject.internal.aop.HiddenClassDefiner
WARNING: sun.misc.Unsafe::staticFieldBase will be removed in a future release
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< com.ibm.cloud:rulesets >-----------------------
[INFO] Building Cloud Internet Services rulesets 99-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] Parameter 'systemPropertyVariables' is unknown for plugin 'jacoco-maven-plugin:0.8.13:prepare-agent (prepare-agent)'
[WARNING] Parameter 'systemPropertyVariables' is unknown for plugin 'jacoco-maven-plugin:0.8.13:report (report)'
[INFO] 
[INFO] --- buildnumber:3.2.1:create (default) @ rulesets ---
[INFO] ShortRevision tag detected. The value is '8'.
[INFO] Executing: /bin/sh -c cd '/Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets' && 'git' 'log' '-1' '--no-merges' '--format=format:%H %aI %aE %aN'
[INFO] Working directory: /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets
[WARNING] The timestampFormat parameter now uses java.text.SimpleDateFormat.
[WARNING] Please update your POM as support for java.text.MessageFormat may be removed.
[INFO] Storing buildNumber: 831a251b at timestamp: 20250903-123543
[INFO] Executing: /bin/sh -c cd '/Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets' && 'git' 'symbolic-ref' 'HEAD'
[INFO] Working directory: /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets
[INFO] Storing scmBranch: cis-rs-ratelimit
[INFO] 
[INFO] --- jacoco:0.8.13:prepare-agent (prepare-agent) @ rulesets ---
[INFO] argLine set to -javaagent:/Users/sirija/.m2/repository/org/jacoco/org.jacoco.agent/0.8.13/org.jacoco.agent-0.8.13-runtime.jar=destfile=/Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/target/jacoco.exec
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ rulesets ---
[INFO] skip non existing resourceDirectory /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/src/main/resources
[INFO] 
[INFO] --- compiler:3.14.0:compile (default-compile) @ rulesets ---
[INFO] Nothing to compile - all classes are up to date.
[INFO] 
[INFO] --- resources:3.3.1:testResources (default-testResources) @ rulesets ---
[INFO] skip non existing resourceDirectory /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/src/test/resources
[INFO] 
[INFO] --- compiler:3.14.0:testCompile (default-testCompile) @ rulesets ---
[INFO] Nothing to compile - all classes are up to date.
[INFO] 
[INFO] --- surefire:3.5.3:test (default-test) @ rulesets ---
[INFO] Surefire report directory: /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/target/surefire-reports
[INFO] Using auto detected provider org.apache.maven.surefire.testng.TestNGProvider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.ibm.cloud.networking.rulesets.v1.RulesetsIT
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Configuring TestNG with: TestNG740Configurator
Setup complete.
7. get entrypoint ruleset versions ✅
6. get entrypoint rulesets ✅
1. list/get rulesets ✅
first CustomRuleset Index => 7
8. get a specific entrypoint ruleset version ✅
9. get a specific entrypoint ruleset version ✅
2. get a ruleset ✅
4. list ruleset versions ✅
7. get entrypoint ruleset versions ✅
6. get entrypoint rulesets ✅
3. update a ruleset ✅
11. create a rule in ruleset ✅
5. get a specific ruleset version ✅
8. get a specific entrypoint ruleset version ✅
10. update a entrypoint ruleset ✅
12. update a rule in ruleset ✅
13. delete a rule in ruleset ✅
14. delete a specific ruleset version ✅
1. list/get rulesets ✅
first CustomRuleset Index => 11
2. get a ruleset ✅
4. list ruleset versions ✅
3. update a ruleset ✅
10. create a rule in ruleset ✅
5. get a specific ruleset version ✅
11. update a rule in ruleset ✅
12. delete a rule in ruleset ✅
13. delete a specific ruleset version ✅
9. update a entrypoint ruleset ✅
Clean up complete.
[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.42 s -- in com.ibm.cloud.networking.rulesets.v1.RulesetsIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco:0.8.13:report (report) @ rulesets ---
[INFO] Loading execution data file /Users/sirija/Desktop/repos/public/networking-java-sdk/modules/rulesets/target/jacoco.exec
[INFO] Analyzed bundle 'Cloud Internet Services rulesets' with 108 classes
[INFO] 
[INFO] --- checkstyle:3.6.0:check (verify-style) @ rulesets ---
[INFO] Starting audit...
Audit done.
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  45.142 s
[INFO] Finished at: 2025-09-03T12:36:28+05:30
[INFO] ------------------------------------------------------------------------

arjunchauhanibm
arjunchauhanibm approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@arjunchauhanibm arjunchauhanibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sirijaibm sirijaibm merged commit d748792 into master Sep 4, 2025
4 checks passed
@sirijaibm sirijaibm deleted the cis-rs-ratelimit branch September 4, 2025 03:24
MalarvizhiK pushed a commit that referenced this pull request Sep 4, 2025
@semantic-release-bot
chore(release): 0.41.0 release notes
0d5f571 
# [0.41.0](0.40.0...0.41.0) (2025-09-04)

### Features

* **CIS:** add ruleset to modules ([#150](#150)) ([d748792](d748792))
@MalarvizhiK
Copy link
Member

MalarvizhiK commented Sep 4, 2025

🎉 This PR is included in version 0.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjunchauhanibm arjunchauhanibm arjunchauhanibm approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sirijaibm @MalarvizhiK @arjunchauhanibm