Skip to content

cherry-pick Kevin's mobile navbar fix from 2025 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
medjakub wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cherry-pick Kevin's mobile navbar fix from 2025 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 7 additions & 53 deletions themes/mainroad/assets/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,8 +590,6 @@ button:not(:-moz-focusring):focus > .menu__btn-title {
background-repeat: no-repeat;
background-position: center 0em;
background-size: 1080px;
padding-top: 22em;
min-height: 430px;
}

@media screen and (min-width: 767px) {
Expand Down Expand Up @@ -1444,11 +1442,6 @@ textarea {
margin: 0;
}

#banner-main {
padding-top: 2em;
min-height: 0px;
}

.logo {
/* text-align: center; */
}
Expand Down Expand Up @@ -1645,34 +1638,10 @@ button:not(:-moz-focusring):focus > .menu__btn-title {
text-transform: uppercase;
}

.menu__list .menu__item .submenu__list {
background: #2a2a2a;
visibility: hidden;
opacity: 0;
position: absolute;
max-width: 15rem;
transition: all 0.5s ease;
border-top: 5px solid #f5821f;
display: none;
}

.menu__list .submenu__list .submenu__list {
width: 7rem; /* or your preferred narrow width */
}

.menu__item.menu__dropdown input[type="checkbox"] {
display: none;
}

.menu__list .menu__item:hover > .submenu__list,
.menu__list .menu__item:focus-within > .submenu__list,
.menu__list .menu__item .submenu__list:hover,
.menu__list .menu__item .submenu__list:focus {
visibility: visible;
opacity: 1;
display: block;
}

.menu__link:hover {
color: #fff;
}
Expand Down Expand Up @@ -1701,7 +1670,7 @@ highlightColor .menu__list--transition {
-webkit-transform 0.15s ease;
}
@media screen and (min-width: 767px) {
/* .menu__list .menu__item:hover .submenu__list,
.menu__list .menu__item:hover .submenu__list,
.menu__list .menu__item:focus-within .submenu__list,
.menu__list .menu__item .submenu__list:hover,
.menu__list .menu__item .submenu__list:focus {
Expand All @@ -1723,7 +1692,7 @@ highlightColor .menu__list--transition {
border-top: 5px solid #f5821f;

display: none;
} */
}
.menu {
border-bottom: 5px solid #f5821f;
}
Expand Down Expand Up @@ -1757,44 +1726,29 @@ highlightColor .menu__list--transition {
top: auto;
}

/* .menu__item.menu__dropdown input[type="checkbox"] + .submenu__list {
.menu__item.menu__dropdown input[type="checkbox"] ~ .submenu__list {
display: grid;
opacity: 0;
grid-template-rows: 0fr;
visibility: visible !important;
transition-property: opacity, grid-template-rows, visibility !important;
}

.menu__item.menu__dropdown input[type="checkbox"]:checked + .submenu__list {
.menu__item.menu__dropdown input[type="checkbox"]:checked ~ .submenu__list {
grid-template-rows: 1fr;
border: none;
opacity: 1;
position: relative;
max-width: 100%;
visibility: visible;
} */

}

.menu__item.menu__dropdown input[type="checkbox"] + .submenu__list {
display: none;
}

.menu__item.menu__dropdown input[type="checkbox"]:checked + .submenu__list {
border: none;
padding-left: 20px;
visibility: visible;
opacity: 1;
display: block;
position: relative;
max-width: 100%;
}

/* .menu__item.menu__dropdown input[type="checkbox"] ~ .submenu__list > * {
.menu__item.menu__dropdown input[type="checkbox"] ~ .submenu__list > * {
overflow-y: hidden;
}
.menu__item.menu__dropdown input[type="checkbox"] ~ .submenu__list > * > * {
padding-left: 20px;
} */
}
}

@media screen and (max-width: 620px) {
Expand Down
106 changes: 52 additions & 54 deletions themes/mainroad/layouts/partials/menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,82 +1,80 @@
{{- if .Site.Menus.main }}
<nav class="menu">
<button class="menu__btn" aria-haspopup="true" aria-expanded="false" tabindex="0">
<span class="menu__btn-title" tabindex="-1">{{ T "menu_label" }}</span>
<span class="menu__btn-title" tabindex="-1">☰</span>
</button>
<ul class="menu__list">
{{- $currentNode := . }}
{{- range .Site.Menus.main }}
{{- if .Name }}


{{- if .HasChildren }}
<li class="menu__item menu__dropdown{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
<label for="{{ .Name }}" class="menu__link">
{{ .Pre }}
<span class="menu__text">{{ .Name }}</span>
<label class="drop-icon" for="{{ .Name }}">▾</label>
<span class="menu__text">
{{ .Name }}</span>
<input type="checkbox" id="{{ .Name }}">
<span class="drop-icon">▾</span>
{{ .Post }}
</a>
<input type="checkbox" id="{{ .Name }}">
<ul class="submenu__list">
{{ range .Children }}
{{- if .HasChildren }}
<li class="menu__item menu__dropdown{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
{{ .Pre }}
<span class="menu__text">{{ .Name }}</span>
<label class="drop-icon" for="{{ .Name }}">▾</label>
{{ .Post }}
</a>
<input type="checkbox" id="{{ .Name }}">
<ul class="submenu__list">
{{ range .Children }}
<li class="menu__item{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
{{ .Pre }}
<span class="menu__text">{{ .Name }}</span>
{{ .Post }}
</a>
</li>
{{ end }}
</ul>
</li>
{{- else }}
<li class="menu__item{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
{{ .Pre }}
<span class="menu__text">{{ .Name }}</span>
{{ .Post }}
</a>
</li>

{{ end }}

{{ end }}
</ul>
</a>
<ul class="submenu__list">
<ul class="'submenu__listwrapper">
{{ range .Children }}
{{- if .HasChildren }}
<li class="menu__item menu__dropdown{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<label for="{{ .Name }}" class="menu__link">
{{ .Pre }}
<span class="menu__text">
{{ .Name }}</span>
<input type="checkbox" id="{{ .Name }}">
<span class="drop-icon">▾</span>
{{ .Post }}
</a>
<ul class="submenu__list">
{{ range .Children }}
<li class="menu__item{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
{{ .Pre }}
<span class="menu__text">
{{ .Name }}</span>
{{ .Post }}
</a>
</li>
{{ end }}
</ul>
</li>
{{- else }}

<li class="menu__item{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
{{ .Pre }}
<span class="menu__text">
{{ .Name }}</span>
{{ .Post }}
</a>
</li>
{{ end }}
{{ end }}
</ul>
</ul>
</li>


{{- else }}


<li class="menu__item{{ if or ($currentNode.IsMenuCurrent "main" .) ($currentNode.HasMenuCurrent "main" .) }} menu__item--active{{ end }}">
<a class="menu__link" href="{{ .URL }}">
{{ .Pre }}
<span class="menu__text">{{ .Name }}</span>
<span class="menu__text">
{{ .Name }}</span>
{{ .Post }}
</a>
</li>


{{- end }}
{{- end }}
{{- end }}
</ul>
</nav>

{{ else -}}
<div class="divider"></div>
{{- end }}