Improved stacktraces for click and clickAndExpectOneOf#5
Open
ILikeToNguyen wants to merge 1 commit intodevelopfrom
Open
Improved stacktraces for click and clickAndExpectOneOf#5ILikeToNguyen wants to merge 1 commit intodevelopfrom
ILikeToNguyen wants to merge 1 commit intodevelopfrom
Conversation
Updates to WebDriverWaitUtils and javadocs, misc 1. Renamed WebDriverWaitUtils#waitUntilWebPageIsValidated to WebDriverWaitUtils#waitUntilPageIsValidated 2. Add private waitForConditionIgnoring methods to WebDriverWaitUtils 3. Misc javadoc corrections 4. Misc import corrections 5. Add new test to BasicPageImplTest
Owner
Author
There was a problem hiding this comment.
Issue found: JUnit tests should include assert() or fail()
Owner
Author
There was a problem hiding this comment.
Issue found: Method names should not contain underscores
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to WebDriverWaitUtils and javadocs, misc
WebDriverWaitUtils#waitUntilPageIsValidated