Fix GLOWS processing DE L1A #2659
Merged
+102
−5,752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxinelasp
requested review from
sdhoyt and
subagonsouth
and removed request for
a team
subagonsouth
approved these changes
Feb 3, 2026
Contributor
subagonsouth
left a comment
subagonsouth
left a comment
There was a problem hiding this comment.
This looks fine as is. Just a couple of minor suggestions to consider.
maxinelasp
merged commit da24adf
into
IMAP-Science-Operations-Center:dev
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
GLOWS L1A processing has been failing because DE processing is kind of fragile. This refactors the way DE processing for L1A works to make it more resilient to weird packets, and adds a try/catch for a complicated piece to try and recover more aggressively.
Overview