-
Notifications
You must be signed in to change notification settings - Fork 0
Add partial backup option #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FreddieAkeroyd
wants to merge
1
commit into
master
Choose a base branch
from
part_backup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Copilot Autofix
AI 3 days ago
The best way to fix this problem is to prevent the password from being printed to the console in clear text. This can be achieved by making a shallow copy of the command list and replacing the password argument (the string starting with
--password=) with a masked version (e.g.,--password=*****) before printing it. The originalcommandlist should remain unaltered, as it is used bysubprocess.runto execute the actual backup.Specifically, in
installation_and_upgrade/part_truncate_archive.py, in the block starting at line 109 where thecommandis built, and in theif args.dry_run:block (line 125–126), modify what is printed:commanddirectly, construct a masked version (command_to_print) where the password is replaced with a masked placeholder (e.g.,*****).No new methods or definitions are strictly needed, as a simple list comprehension suffices; however, you could factor out the masking logic into a small helper function for clarity if desired. No new imports are required.