Skip to content

Bugfix/83 validation object expects all properties to be set #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IamSebastianDev wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Bugfix/83 validation object expects all properties to be set #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd8b35
fix: improve type safety for validator functions
IamSebastianDev Apr 10, 2023
00d3226
fix: make passing a partially validated set possible
IamSebastianDev Apr 10, 2023
e4d02ba
test: fix tests
IamSebastianDev Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/ValidationStrategy.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
import type { ValidatorFunction } from './ValidatorFunction';

export type ValidationStrategy<T extends Record<string, unknown>> = {
[Prop in keyof T]: ValidatorFunction<T[Prop], T> | ValidatorFunction<T[Prop], T>[];
[Prop in keyof T]: ValidatorFunction | ValidatorFunction[];
};
2 changes: 1 addition & 1 deletion src/types/Validator.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import type { ValidationStrategy } from './ValidationStrategy';
import type { ValidatorFunction } from './ValidatorFunction';

export type Validator<T extends Record<string, unknown>> = {
validate: ValidationStrategy<T>;
validate: ValidationStrategy<Partial<T>>;
};
4 changes: 4 additions & 0 deletions tests/Validators.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,13 +338,17 @@ test('[Validators] ValidateNested correctly validates a deeply nested property',

test('[Validators] ValidateNested correctly validates a value that is not an object', (t) => {
const value = 'test';

//@ts-expect-error
const validator = ValidateNested({ key: 'test' });

t.throws(() => validator(value, 'test-property'));
});

test('[Validators] ValidateNested correctly validates a value that is an empty object', (t) => {
const value = {};

//@ts-expect-error
const validator = ValidateNested({ key: 'test' });

t.throws(() => validator(value, 'test-property'));
Expand Down