Skip to content

Wrong initialization of heartbeat on the Azure Web PubSub store #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesusmpc merged 2 commits into from
May 13, 2026
Merged

Wrong initialization of heartbeat on the Azure Web PubSub store #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6208e38
chore: initial commit
jesusmpc May 13, 2026
dd4fd0e
fix: initialize last heartbeat value on connection open
jesusmpc May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions code/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- [#1057](https://github.com/InditexTech/weavejs/issues/1057) Provide an API to crop an image programmatically using an image and an element (bounding box)

### Fixed

- [#1059](https://github.com/InditexTech/weavejs/issues/1059) Wrong initialization of heartbeat on the Azure Web PubSub store

## [3.8.4] - 2026-05-12

### Fixed
Expand Down
4 changes: 4 additions & 0 deletions code/packages/store-azure-web-pubsub/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@ export class WeaveStoreAzureWebPubSubSyncClient extends Emittery {
};

websocket.onclose = (e) => {
console.log(e);
console.log(`🚫 [Azure Web PubSub] closed, code: ${e.code}`);

this.destroyCheckHeartbeat();
Expand Down Expand Up @@ -509,6 +510,8 @@ export class WeaveStoreAzureWebPubSubSyncClient extends Emittery {
};

websocket.onopen = () => {
this._lastHeartbeatTime = Date.now();

this.setAndEmitStatusInfo(
WEAVE_STORE_AZURE_WEB_PUBSUB_CONNECTION_STATUS.CONNECTED
);
Expand Down Expand Up @@ -579,6 +582,7 @@ export class WeaveStoreAzureWebPubSubSyncClient extends Emittery {
private setupCheckHeartbeat() {
this._checkHeartbeatId = setInterval(() => {
const now = Date.now();

if (
now - this._lastHeartbeatTime >
this._synClientOptions.heartbeat.checkWindowTimeMs
Expand Down
6 changes: 5 additions & 1 deletion docs/content/docs/main/changelog/3.x/3.9.0.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: v3.9.0
description: API to crop an image given a reference element (bounding box)
description: API to crop an image given a reference element (bounding box) and minor fix on Azure Web PubSub store heartbeat
---

## Metadata
Expand All @@ -10,3 +10,7 @@ description: API to crop an image given a reference element (bounding box)
### Added

- [#1057](https://github.com/InditexTech/weavejs/issues/1057) Provide an API to crop an image programmatically using an image and an element (bounding box)

### Fixed

- [#1059](https://github.com/InditexTech/weavejs/issues/1059) Wrong initialization of heartbeat on the Azure Web PubSub store
Loading