psoc6: Extend modbluetooth from extmod.#227
Conversation
|
Code size report: |
ports/psoc6/Makefile
Outdated
|
|
||
| MPY_CROSS_FLAGS += -march=armv7m | ||
|
|
||
| ifeq ($(MICROPY_PY_BLUETOOTH),1) |
There was a problem hiding this comment.
Should not this belong to the mtb-psoc6-libs?
That module is in charge of handling this file and generating the sources. Is that of any concern of the mpy side?
There was a problem hiding this comment.
Additionally, the CI is failing 😢
There was a problem hiding this comment.
Ahh the CI failing is I should update the exp file now. I will fix that.
There was a problem hiding this comment.
Should not this belong to the mtb-psoc6-libs? That module is in charge of handling this file and generating the sources. Is that of any concern of the mpy side?
In mtb-psoc6-libs/makefile_mtb.mk, I did not find any inclusions from micropython/ports/psoc6 path. I was believing if that needed to be consistent henceforth as well and moved the ble target to location where it is now. I think other way should also work, if it is ok to include vice versa?
There was a problem hiding this comment.
I am referring to the .bt file. Micropython should not need to know about it. Replied in the mtb-integration.
|
The time_pulse test is failing but should not ideally be anything impacted from changes in this PR. I suggest we ignore this for now and when en-ble branch is merged to ports-psoc6-main, we can check and fix (if needed any). Does that work? |
Yes please. If there is not evident effect about this changes, we make sure later when merging against the main. Also I think if you rebase "ports-psoc6-main" into "en-ble" that might be "fixed". |
Yes I will do that too |
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
05c1544 to
4f24b6f
Compare
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Summary