feat: Caldav client configuration - #145
Open
benjaminVadon wants to merge 3 commits into
Open
benjaminVadon wants to merge 3 commits into
benjaminVadon wants to merge 3 commits into
Conversation
benjaminVadon
requested review from
sirambd
and
a balanced review from Copilot
August 20, 2026 10:25
|
This PR/issue depends on:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Configures the Rust CalDAV client at app startup and adds debug-only proxy interception support.
Changes:
- Sets the CalDAV user agent.
- Adds debug proxy and custom CA configuration.
- Documents and excludes local proxy assets.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
app/src/release/java/com/infomaniak/calendar/utils/CaldavDebugConfig.kt |
Provides the release no-op configuration. |
app/src/main/java/com/infomaniak/calendar/MainApplication.kt |
Initializes the CalDAV client. |
app/src/debug/java/com/infomaniak/calendar/utils/CaldavDebugConfig.kt |
Configures debug proxy interception. |
app/build.gradle.kts |
Exposes the local proxy URL to debug builds. |
app/AGENTS.md |
Documents CalDAV configuration and debugging. |
.gitignore |
Excludes the developer-specific proxy CA. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+32
to
+33
| import com.infomaniak.multiplatform_calendar.data.remote.caldav.CaldavClientConfig | ||
| import com.infomaniak.multiplatform_calendar.data.remote.caldav.configureCaldavClient |
| `local.properties` (git-ignored): | ||
|
|
||
| ```properties | ||
| caldavDebugProxyUrl=http://10.0.2.2:9090 |
benjaminVadon
force-pushed
the
caldav-client-configuration
branch
6 times, most recently
from
August 25, 2026 09:39
7038b65 to
4161682
Compare
benjaminVadon
force-pushed
the
caldav-client-configuration
branch
3 times, most recently
from
September 8, 2026 13:18
8f787a3 to
cbfa574
Compare
benjaminVadon
force-pushed
the
caldav-client-configuration
branch
from
September 8, 2026 13:25
cbfa574 to
1f3a16f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of caldav library configuration, mainly user agent and request interception ability with proxyman
depends on Infomaniak/multiplatform-calendar#129